Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fixes #3640 Update the keyboard layout when shown #3646

Closed
wants to merge 1 commit into from
Closed

Fixes #3640 Update the keyboard layout when shown #3646

wants to merge 1 commit into from

Conversation

keianhzo
Copy link
Contributor

@keianhzo keianhzo commented Jul 7, 2020

Fixes #3640 Update the keyboard layout when shown

@keianhzo keianhzo self-assigned this Jul 7, 2020
@keianhzo keianhzo requested a review from daoshengmu July 7, 2020 14:26
@keianhzo keianhzo added the Uplift PR that needs to be uplifted. label Jul 7, 2020
@daoshengmu
Copy link
Contributor

It looks like it is not what we want. We should switch to the alphabetic keyboard instead of the symbol keyboard.

daoshengmu
daoshengmu suggested changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@daoshengmu daoshengmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will switch to the symbol mode. I think switching to the alphabetic mode is what we want.

@bluemarvin
Copy link
Contributor

bluemarvin commented Jul 7, 2020 •
edited
Loading

It will switch to the symbol mode. I think switching to the alphabetic mode is what we want.

The behavior in this PR matches the other keyboard. If you think the keyboard should be reset to alphabetic mode after dismissal, that should be a separate issue.

I see the problem now. The symbol keyboard is always restored regardless of the mode the keyboard when it is dismissed.

@bluemarvin bluemarvin self-requested a review July 7, 2020 21:00
@bluemarvin bluemarvin removed the Uplift PR that needs to be uplifted. label Jul 7, 2020
@bluemarvin
Copy link
Contributor

Fixed by #3650

@bluemarvin bluemarvin closed this Jul 7, 2020
@bluemarvin bluemarvin deleted the v12/update_layout_show branch July 15, 2020 20:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daoshengmu daoshengmu daoshengmu requested changes

@bluemarvin bluemarvin Awaiting requested review from bluemarvin

Assignees

@keianhzo keianhzo

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@keianhzo @daoshengmu @bluemarvin