Hack: Copy metadata module to avoid uniffi_core dependency #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
force-pushed
the
copied-metadata-module-main
branch
2 times, most recently
from
5c0deeb
to
124959b
Compare
travis79
approved these changes
Jul 25, 2023
|
I wonder if things have changed enough that could move |
In m-c we're running into linking issues in `uniffi_macros`,
where it's missing symbols coming from `uniffi_core`:
/bin/ld: uniffi_foreign_executor_callback_set: undefined version:
/bin/ld: failed to set dynamic section sizes: bad value
That's most likely this issue on Rust:
rust-lang/rust#111888
It's called out that this likely actually broke because of another PR:
rust-lang/rust#99944
Despite this bug there's a bit of an issue in UniFFI to begin with:
We're exporting `extern "C"` functions from a crate that is a dependency
of some other crates, including `uniffi_macros`, and thus the symbols
land in a part where they are not needed.
However for `uniffi_meta` in particular we don't need much from
`uniffi_core`, so for now we just copy the necessary bits to get it all
working.
badboy
force-pushed
the
copied-metadata-module-main
branch
from
124959b
to
d574d18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In m-c we're running into linking issues in
uniffi_macros, where it's missing symbols coming fromuniffi_core:That's most likely this issue on Rust:
rust-lang/rust#111888
It's called out that this likely actually broke because of another PR: rust-lang/rust#99944
Despite this bug there's a bit of an issue in UniFFI to begin with: We're exporting
extern "C"functions from a crate that is a dependency of some other crates, includinguniffi_macros, and thus the symbols land in a part where they are not needed.However for
uniffi_metain particular we don't need much fromuniffi_core, so for now we just copy the necessary bits to get it all working.This is tackling the issues uncovered in https://bugzilla.mozilla.org/show_bug.cgi?id=1840044
It's a short-term fix that I want to release as a patch version 0.24.2 without anything else from
main(I have a separate patch for only the 0.24.2 fix then