FIX: Evaluation of ?? #1624
Merged
FIX: Evaluation of ?? #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xe
force-pushed
the
scratch/satish/fix-nullish-coalescing-1623
branch
from
96007ee
to
a90f268
Compare
p-bakker
reviewed
Sep 12, 2024
tests/src/test/java/org/mozilla/javascript/tests/NullishCoalescingOpTest.java
Outdated
Show resolved
Hide resolved
|
Assume this isn't covered by any test from test262? |
|
Looks like the pipeline fails due to some failing tests |
Yeah, this isn't covered. Will raise a PR against 262 to add this scenario. |
I'm working on fixing those. |
0xe
force-pushed
the
scratch/satish/fix-nullish-coalescing-1623
branch
from
a90f268
to
e308753
Compare
0xe
force-pushed
the
scratch/satish/fix-nullish-coalescing-1623
branch
from
e308753
to
36d744d
Compare
p-bakker
reviewed
Sep 13, 2024
|
Besides that minor comment this LGTM |
|
Looks good to me too. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1623