Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button rework #36

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Button rework #36

merged 2 commits into from
Jul 12, 2023

Conversation

nickgrato
Copy link
Contributor

@nickgrato nickgrato commented Jun 20, 2023 •
edited
Loading

changing the enums to types. We don't need to import the enum every time we use these components if we can just use union types with strings

Adding updated fade in functionality.

@nickgrato nickgrato requested a review from nikk15 June 20, 2023 23:33
nikk15
nikk15 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@nikk15 nikk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Much prefer this to the enums imported :)

@nickgrato nickgrato merged commit 8e3f4d4 into main Jul 12, 2023
@nickgrato nickgrato deleted the button-rework branch July 12, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikk15 nikk15 nikk15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickgrato @nikk15