Send a baseline at startup if the previous session ended abruptly
#687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexterp37
force-pushed
the
baseline_dirty_startup
branch
from
014d136
to
a1d1097
Compare
Dexterp37
commented
Feb 5, 2020
glean-core/android/src/main/java/mozilla/telemetry/glean/Glean.kt
Outdated
Show resolved
Hide resolved
badboy
requested changes
Feb 6, 2020
glean-core/android/src/main/java/mozilla/telemetry/glean/scheduler/GleanLifecycleObserver.kt
Show resolved
Hide resolved
glean-core/android/src/test/java/mozilla/telemetry/glean/GleanTest.kt
Outdated
Show resolved
Hide resolved
Dexterp37
force-pushed
the
baseline_dirty_startup
branch
from
a1d1097
to
627b659
Compare
badboy
approved these changes
Feb 10, 2020
This is a user lifetime Boolean metric that allows to detect, on mobile, whenever applications are force-closed.
This only covers the Kotlin part, which is time sensitive.
Dexterp37
force-pushed
the
baseline_dirty_startup
branch
from
627b659
to
89ba9b1
Compare
mdboom
approved these changes
Feb 11, 2020
| INTERNAL_STORAGE, | ||
| &dirty_bit_metric.meta().identifier(self), | ||
| ) { | ||
| Some(Metric::Boolean(b)) => b, |
There was a problem hiding this comment.
Could use unwrap_or(false) instead of this match clause here...
There was a problem hiding this comment.
By changing to that, we get a expected bool, found enum metrics::Metric`` - leaving this as it is, we can always fixup later!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to address the problem of 'force-close' interfering with the
baselineping. It implements the following logic:In addition to the current behaviour:
dirty_startup(a new standard field being added to all pings, see 1557048: Add reason codes to the metrics ping #649 );This will guarantee that whenever the product using the Glean SDK is force-closed or crashes before it has the chance to send a baseline ping with a specific reason, signaling that there was a dirty flag set.
Important: there will be no foreground duration reported with the baseline ping with reason “dirty-startup”.
TODO