Bug 1897219 - Add a global map of ping->[ride-along-pings] so we can correctly call it #2839
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now adds a configuration option to pass a map along that would otherwise be set on the individual ping instances.
It thus works for the builtin pings.
The ping-specific list still works and is preferred, only if empty we go for the top-level map.
Aside:
Note that this is technically a breaking change because the whole configuration is public and we cannot provide default values in Rust (we should really fix that as a breaking-change-thing).
If we go this route I'd still vote for handling this as a feature change only (and we'll mark the non-builder Rust API as "private", so changing it isn't a breaking change anymore). This saves us from the hefty coordination with a-s.
Consumers are fine either way, because we can handle the defaults in the bindings and for RLB we're the only ones using it and can deal with it.
I have the patch for m-c ready that would use this too.