Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1897219 - Add a global map of ping->[ride-along-pings] so we can correctly call it #2839

Merged
merged 1 commit into from
May 23, 2024

Conversation

badboy
Copy link
Member

@badboy badboy commented May 17, 2024

This now adds a configuration option to pass a map along that would otherwise be set on the individual ping instances.
It thus works for the builtin pings.

The ping-specific list still works and is preferred, only if empty we go for the top-level map.

Aside:
Note that this is technically a breaking change because the whole configuration is public and we cannot provide default values in Rust (we should really fix that as a breaking-change-thing).
If we go this route I'd still vote for handling this as a feature change only (and we'll mark the non-builder Rust API as "private", so changing it isn't a breaking change anymore). This saves us from the hefty coordination with a-s.
Consumers are fine either way, because we can handle the defaults in the bindings and for RLB we're the only ones using it and can deal with it.

I have the patch for m-c ready that would use this too.

@badboy badboy marked this pull request as ready for review May 21, 2024 12:01
@badboy badboy requested a review from a team as a code owner May 21, 2024 12:01
@badboy badboy requested review from travis79 and removed request for a team May 21, 2024 12:01
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.60%. Comparing base (7b89f4a) to head (2d435ca).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2839   +/-   ##
=======================================
  Coverage   18.60%   18.60%           
=======================================
  Files           1        1           
  Lines          43       43           
=======================================
  Hits            8        8           
  Misses         35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badboy badboy merged commit 60647f1 into main May 23, 2024
34 checks passed
@badboy badboy deleted the schedules-pings-map branch May 23, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants