Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Build _only_ a staticlib. #2285

Merged
merged 3 commits into from
Nov 23, 2022
Merged

Conversation

badboy
Copy link
Member

@badboy badboy commented Nov 23, 2022

--crate-type was stabilized in cargo 1.64.0 (cargo#10838)

@badboy badboy requested a review from travis79 November 23, 2022 14:28
@badboy badboy requested a review from a team as a code owner November 23, 2022 14:28
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 26.47% // Head: 26.47% // No change to project coverage 👍

Coverage data is based on head (fac66cc) compared to base (8428a49).
Patch has no changes to coverable lines.

❗ Current head fac66cc differs from pull request most recent head 89934a0. Consider uploading reports for the commit 89934a0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2285   +/-   ##
=======================================
  Coverage   26.47%   26.47%           
=======================================
  Files           1        1           
  Lines          34       34           
=======================================
  Hits            9        9           
  Misses         25       25           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single question about embedding the framework, no need to block on the answer.

CD70CF8E2850D4B700FC2014 /* Swifter in Frameworks */ = {isa = PBXBuildFile; productRef = CD70CF8D2850D4B700FC2014 /* Swifter */; };
CD70CF902850D4BA00FC2014 /* Gzip in Frameworks */ = {isa = PBXBuildFile; productRef = CD70CF8F2850D4BA00FC2014 /* Gzip */; };
CD802A47292E5AC800D46BE9 /* Glean.xcframework in Frameworks */ = {isa = PBXBuildFile; fileRef = CD70CF8B2850D3F400FC2014 /* Glean.xcframework */; };
CD802A48292E5AC800D46BE9 /* Glean.xcframework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = CD70CF8B2850D3F400FC2014 /* Glean.xcframework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we need to embed this framework in the app now? Is this something downstream consumers will need to do as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the sample app, without embedding it it wouldn't work on my test device.
Other users consume it as a Swift package through glean-swift, which does the right thing already.
Only our sample app uses the bare xcframework, and those need to be embedded to run on actual hardware.

@badboy badboy force-pushed the ios/no-more-dylib-for-xcframework branch 2 times, most recently from 7ce2ebd to fac66cc Compare November 23, 2022 15:07
@badboy badboy force-pushed the ios/no-more-dylib-for-xcframework branch from fac66cc to 89934a0 Compare November 23, 2022 15:40
@badboy badboy merged commit eb40626 into main Nov 23, 2022
@badboy badboy deleted the ios/no-more-dylib-for-xcframework branch November 23, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants