Bug 1634064 - Implement the 'X-Source-Tags' header #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
reviewed
Jul 20, 2020
glean-core/android/src/main/java/mozilla/telemetry/glean/debug/GleanDebugActivity.kt
Show resolved
Hide resolved
glean-core/android/src/main/java/mozilla/telemetry/glean/debug/GleanDebugActivity.kt
Show resolved
Hide resolved
mdboom
suggested changes
Jul 20, 2020
Before this PR, validation functions were also performing the parsing of the data from environment variables. Unfortunately, by being entangled, it was hard to provide options that were not of type `String`. This PR fixes the problem by introducing an `extraction` function: when instantiating a new option, we should define how we want the data to be extracted from environment variables.
This further decouples validation from extraction by making sure the validation function only returns true or false, instead of the validated value.
This option allows specifying a list of tags to be attached to the ping upload requests, in order for the data users or pipeline to tell data apart.
This adds the FFI boilerplate and changes the DebugActivity in order to support the new option. Other language bindings, except for Swift, will be supported using the environment variables.
mdboom
approved these changes
Jul 20, 2020
badboy
approved these changes
Jul 21, 2020
glean-core/android/src/main/java/mozilla/telemetry/glean/debug/GleanDebugActivity.kt
Outdated
Show resolved
Hide resolved
glean-core/android/src/main/java/mozilla/telemetry/glean/debug/GleanDebugActivity.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the new ping tagging system in the Glean SDK. It adds a CLI option for
adb, all the glean-core implementation and environment variable support.Please note that I had to refactor the debug options module a bit in order to allow using non-
Stringoption types.