Bug 1650787 - Implement JWE metric in the bindings #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexterp37
requested changes
Jul 20, 2020
glean-core/android/src/main/java/mozilla/telemetry/glean/private/JweMetricType.kt
Outdated
Show resolved
Hide resolved
glean-core/android/src/main/java/mozilla/telemetry/glean/private/JweMetricType.kt
Outdated
Show resolved
Hide resolved
glean-core/android/src/main/java/mozilla/telemetry/glean/private/JweMetricType.kt
Outdated
Show resolved
Hide resolved
* setWithCompactRepr -> setWithCompactRepresentation * testGetValueAsPeriodDelimitedString -> testGetCompactRepresentation
Dexterp37
approved these changes
Jul 20, 2020
mdboom
approved these changes
Jul 20, 2020
glean-core/android/src/main/java/mozilla/telemetry/glean/private/JweMetricType.kt
Show resolved
Hide resolved
glean-core/android/src/test/java/mozilla/telemetry/glean/private/JweMetricTypeTest.kt
Show resolved
Hide resolved
Dexterp37
reviewed
Jul 21, 2020
Dexterp37
reviewed
Jul 21, 2020
mdboom
approved these changes
Jul 21, 2020
* Return `JweData` struct from test_get_value (all bindings); * Add explicit test for `test_get_value` for each binding; * Fix docstring for python get_test_* functions.
travis79
requested changes
Jul 21, 2020
travis79
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.