-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nimbus): Summary page timeline #11393
Open
yashikakhurana
wants to merge
9
commits into
mozilla:main
Choose a base branch
from
yashikakhurana:11361/summary_page_timeline
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+192
−12
Open
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c841680
feat(nimbus): Summary page timeline
yashikakhurana 9d99f51
feat(nimbus): Summary page timeline
yashikakhurana 0f4d2ac
feat(nimbus): Update headings
yashikakhurana d09b1d4
feat(nimbus): Review status
yashikakhurana 9ace2eb
feat(nimbus): Review status
yashikakhurana 678d4a3
feat(nimbus): format
yashikakhurana 99615a1
feat(nimbus): update classes
yashikakhurana f7bbce8
feat(nimbus): update classes
yashikakhurana 18b5967
feat(nimbus): update complete end date
yashikakhurana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
experimenter/experimenter/nimbus_ui_new/templates/nimbus_experiments/timeline.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
<div class="col-6"> | ||
<ul class="list-group list-group-horizontal justify-content-between mb-3"> | ||
<!-- Draft Status --> | ||
<li class="list-group-item flex-fill text-center d-flex flex-column justify-content-center {% if experiment.status == 'Draft' and experiment.publish_status == 'Idle' %} bg-primary text-light {% else %} mode-sensitive text-dark {% endif %}"> | ||
<strong>Draft</strong> | ||
<small>{{ experiment.draft_date|default:'---' }}</small> | ||
</li> | ||
<!-- Preview Status --> | ||
<li class="list-group-item flex-fill text-center d-flex flex-column justify-content-center {% if experiment.status == 'Preview' and experiment.publish_status == 'Idle' %} bg-primary text-light {% else %} mode-sensitive text-dark {% endif %}"> | ||
<strong>Preview</strong> | ||
<small>{{ experiment.preview_date|default:'---' }}</small> | ||
</li> | ||
<!-- Review Status --> | ||
<li class="list-group-item flex-fill text-center d-flex flex-column justify-content-center {% if experiment.publish_status != 'Idle' %} {% if experiment.status == 'Preview' or experiment.status == 'Draft' %} bg-primary text-light {% else %} mode-sensitive text-dark {% endif %} {% else %} mode-sensitive text-dark {% endif %}"> | ||
<strong>Review</strong> | ||
<small>{{ experiment.review_date|default:'---' }}</small> | ||
</li> | ||
<!-- Live Status --> | ||
<li class="list-group-item flex-fill text-center d-flex flex-column justify-content-center {% if experiment.status == 'Live' %} bg-primary text-light {% else %} mode-sensitive text-dark {% endif %}"> | ||
<strong>Live</strong> | ||
<small>{{ experiment.start_date|default:'---' }}</small> | ||
</li> | ||
<!-- Complete Status --> | ||
<li class="list-group-item flex-fill text-center d-flex flex-column justify-content-center {% if experiment.status == 'Complete' %} bg-primary text-light {% else %} mode-sensitive text-dark {% endif %}"> | ||
<strong>Complete</strong> | ||
<small>{{ experiment.end_date|default:'---' }}</small> | ||
</li> | ||
</ul> | ||
</div> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.