Prune non-importable audits. #583
Merged
+354
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mystor
requested changes
Dec 8, 2023
| @@ -2744,7 +2756,9 @@ fn resolve_package_required_entries( | |||
| DeltaEdgeOrigin::Unpublished { unpublished_index } => { | |||
| add_entry(RequiredEntry::Unpublished { unpublished_index }) | |||
| } | |||
| DeltaEdgeOrigin::StoredLocalAudit { .. } => {} | |||
| DeltaEdgeOrigin::StoredLocalAudit { audit_index, .. } => { | |||
| add_entry(RequiredEntry::LocalAudit { audit_index }) | |||
There was a problem hiding this comment.
We only need to add an entry here if the type is non-importable.
There was a problem hiding this comment.
While that's technically true (since that's the only thing that would be a candidate for pruning in the first place), I thought it'd be more intuitive to track all local audits that are used.
There was a problem hiding this comment.
I didn't track all of them originally because that information exists in DeltaEdgeOrigin and RequiredEntry only exists for pruning. Doesn't matter a ton though.
This addresses part of mozilla#580.
afranchuk
force-pushed
the
non-importable-pruning
branch
from
d9d08ef
to
e78e696
Compare
mystor
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses part of #580.