Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FXIOS-9962 - Add shared files from mozilla central for password generator #21885

Conversation

issammani
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

This PR:

  • Adds LoginFormFactory.sys.mjs which is a utiliy to deal with forms and inputs on a document.
  • Adds NewPasswordModel.sys.mjs which a pre-trained fathom model to detect new-password fields.
  • Adds PasswordGenerator.sys.mjs which is used to generate the secure passwords based on rules.
  • Adds PasswordRulesParser.sys.mjs which will parse the rules from RemotePasswordRules.json.
  • Adds LoginManager.shared.sys.mjs which has shared utils from the password manager.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@isabelrios
Copy link
Contributor

There is a unit test failure in this PR: test_didTapMainButton_withSaveState_callsAddCreditCard
if it is not related to the changes, you may need to re-run it again

@mobiletest-ci-bot
Copy link

Messages
📖 Edited 1 files
📖 Created 0 files

Generated by 🚫 Danger Swift against 9d807d2

@issammani issammani merged commit 8065dff into mozilla-mobile:main Sep 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants