-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor - auto update credential provider script #21747
Conversation
Generated by 🚫 Danger Swift against 84aa774 |
With changes in this PR there is a UI Tests failing consistently that may be related:
@issammani we would need to double check if tests need to be updated due to changes in the UI due to these changes or if there might be a regression introduced cc @dragosb01 |
I think this one is an issue on the JS. Let me double check and see what's going on. We changed a few things on central lately. |
thanks, let us know if you need more info. Looks like the failure is that we are missing the |
Yes that's it thanks. I was able to reproduce locally and pin point the root issue. We need to wait for:
I marked this as DON'T MERGE for now. Will update once we have both bits in. |
@issammani Approved the PR - #21750 Going to give you prelim approval for this |
This pipeline had to be rebuilt for some failing tests |
8845feb
to
84aa774
Compare
@nbhasin2 @isabelrios I see one more failure but I don't think this is related. Can we merge this ? |
That's a test that failed but passed in a retry, bitrise general check is green and PR is not blocked to be merged, so everything looks good ✅ |
Automated changes by create-pull-request GitHub action