Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - auto update credential provider script #21747

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 3, 2024

Automated changes by create-pull-request GitHub action

@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Sep 3, 2024

Messages
📖 Edited 10 files
📖 Created 1 files

Generated by 🚫 Danger Swift against 84aa774

@isabelrios
Copy link
Contributor

isabelrios commented Sep 3, 2024

With changes in this PR there is a UI Tests failing consistently that may be related:

  • testAutofillCreditCardsToggleOnOff()

@issammani we would need to double check if tests need to be updated due to changes in the UI due to these changes or if there might be a regression introduced

cc @dragosb01

@issammani
Copy link
Collaborator

@issammani we would need to double check if tests need to be updated due to changes in the UI due to these changes or if there might be a regression introduced

I think this one is an issue on the JS. Let me double check and see what's going on. We changed a few things on central lately.

@isabelrios
Copy link
Contributor

@issammani we would need to double check if tests need to be updated due to changes in the UI due to these changes or if there might be a regression introduced

I think this one is an issue on the JS. Let me double check and see what's going on. We changed a few things on central lately.

thanks, let us know if you need more info. Looks like the failure is that we are missing the Used save card option
Screenshot 2024-09-03 at 10 57 07

@issammani
Copy link
Collaborator

thanks, let us know if you need more info. Looks like the failure is that we are missing the Used save card option

Yes that's it thanks. I was able to reproduce locally and pin point the root issue. We need to wait for:

I marked this as DON'T MERGE for now. Will update once we have both bits in.

@issammani issammani added the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Sep 3, 2024
@nbhasin2
Copy link
Contributor

nbhasin2 commented Sep 4, 2024

@issammani Approved the PR - #21750

Going to give you prelim approval for this

@nbhasin2
Copy link
Contributor

nbhasin2 commented Sep 4, 2024

This pipeline had to be rebuilt for some failing tests

@issammani issammani removed the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Sep 5, 2024
@issammani
Copy link
Collaborator

@nbhasin2 @isabelrios I see one more failure but I don't think this is related. Can we merge this ?

@isabelrios
Copy link
Contributor

@nbhasin2 @isabelrios I see one more failure but I don't think this is related. Can we merge this ?

That's a test that failed but passed in a retry, bitrise general check is green and PR is not blocked to be merged, so everything looks good ✅

@issammani issammani merged commit eedf1b1 into main Sep 5, 2024
8 of 9 checks passed
@issammani issammani deleted the update-cred-provider-script branch September 5, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants