This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Bug 1623601 - Add visual metrics tasks to nightly browsertime tests. #9248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanLorenzo
approved these changes
Mar 19, 2020
| @@ -56,6 +56,6 @@ def filter(task, parameters): | |||
| @_target_task('browsertime') | |||
| def target_tasks_raptor(full_task_graph, parameters, graph_config): | |||
| def filter(task, parameters): | |||
| return task.kind == 'browsertime' | |||
| return task.kind == 'browsertime' or task.kind == 'visual-metrics' | |||
There was a problem hiding this comment.
Python nit: This can be simplified into
Suggested change
| return task.kind == 'browsertime' or task.kind == 'visual-metrics' | |
| return task.kind in ('browsertime', 'visual-metrics') |
|
@JohanLorenzo I've fixed the nit issue, and it's ready for landing when the PR checks are done. Thanks for the review! |
Codecov Report
@@ Coverage Diff @@
## master #9248 +/- ##
=========================================
Coverage 19.49% 19.49%
Complexity 511 511
=========================================
Files 329 329
Lines 13155 13155
Branches 1748 1748
=========================================
Hits 2565 2565
Misses 10364 10364
Partials 226 226 Continue to review full report at Codecov.
|
|
Failure is unrelated to the patch. Landing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the visual-metrics tasks to the nightly browsertime cron tests. They are currently being removed because they don't have a
browsertimekind.