Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #8017: remove redundant string per localization team #9068

Merged
merged 1 commit into from
Mar 10, 2020
Merged

For #8017: remove redundant string per localization team #9068

merged 1 commit into from
Mar 10, 2020

Conversation

severinrudie
Copy link
Contributor

@severinrudie severinrudie commented Mar 9, 2020 •
edited
Loading

Based on conversation in #8953 (comment)

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@severinrudie severinrudie mentioned this pull request Mar 9, 2020
Merged
4 tasks
@severinrudie
Copy link
Contributor Author

Blocked on approval from @flodolo. See #8953 (comment)

flodolo
flodolo approved these changes Mar 10, 2020
View reviewed changes
Copy link

@flodolo flodolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this works 👍

@severinrudie severinrudie merged commit 8663c47 into mozilla-mobile:master Mar 10, 2020
@severinrudie severinrudie deleted the 8017-fix-strings-again branch March 10, 2020 20:29
@liuche liuche mentioned this pull request Mar 12, 2020
Closed
32 tasks
severinrudie pushed a commit to severinrudie/fenix that referenced this pull request Mar 18, 2020
@severinrudie
For mozilla-mobile#8017: remove redundant string per localization team (
e6c7ebe 
mozilla-mobile#9068)

Based on conversation in mozilla-mobile#8953 (comment)
@liuche liuche mentioned this pull request Mar 24, 2020
Closed
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liuche liuche liuche approved these changes

@flodolo flodolo flodolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@severinrudie @liuche @flodolo