Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Re-enable ETP UI tests and update local asset #8733

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

AaronMT
Copy link
Contributor

@AaronMT AaronMT commented Feb 25, 2020

Closes #8732

@AaronMT AaronMT requested a review from KMaragh February 25, 2020 15:52
@AaronMT AaronMT self-assigned this Feb 25, 2020
@codecov-io
Copy link

codecov-io commented Feb 25, 2020

Codecov Report

Merging #8733 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8733   +/-   ##
=========================================
  Coverage     19.02%   19.02%           
  Complexity      500      500           
=========================================
  Files           327      327           
  Lines         12985    12985           
  Branches       1713     1713           
=========================================
  Hits           2471     2471           
  Misses        10307    10307           
  Partials        207      207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf34b4...537ff90. Read the comment docs.

@AaronMT
Copy link
Contributor Author

AaronMT commented Feb 25, 2020

Status didn't bubble up but a re-enabled test hit the crash in #8704

@AaronMT AaronMT force-pushed the etp-ui-tests-fix-reenable branch 2 times, most recently from a7d3aac to c1f3eaa Compare February 26, 2020 17:43
@AaronMT AaronMT added eng:automation Build automation, Continuous integration, .. eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer labels Feb 26, 2020
@AaronMT AaronMT force-pushed the etp-ui-tests-fix-reenable branch 2 times, most recently from 20b7d23 to 9e8e5a0 Compare February 26, 2020 21:17
@AaronMT
Copy link
Contributor Author

AaronMT commented Feb 26, 2020

For whatever reason, on a Nexus 6 (of which is not reproducible in an equivalent AVD), in testStrictVisitDisable, the click to open Settings in the menu is not happening. I'm trying multiple approaches.

@AaronMT
Copy link
Contributor Author

AaronMT commented Feb 26, 2020

02-26 17:32:11.738: I/ViewInteraction(8647): Checking 'MatchesViewAssertion{viewMatcher=at least 100 percent of the view's area is displayed to the user.}' assertion on view (with res-name that is "text" and with string from resource id: <2131886186>[browser_menu_settings] value: Settings)

02-26 17:32:11.741: I/ViewInteraction(8647): Performing 'single click' action on view (with res-name that is "text" and with string from resource id: <2131886186>[browser_menu_settings] value: Settings)

02-26 17:32:11.794: D/App(8647): DebugMetricController: track event: BrowserMenuItemTapped(item=SETTINGS)

The video shows no click on settings. I'll have to investigate further. Or just keep this disabled on this device.

@AaronMT AaronMT force-pushed the etp-ui-tests-fix-reenable branch 5 times, most recently from f0c2d8d to bad35bc Compare March 2, 2020 18:27
fix: more reliable scroll on descendant in recycler view

fix: ktlint

fix: wait adjust

fix: add more verification steps

fix: cleanup + ensure correct setting resource in menu

fix: try another click approach for failing Nexus 6

fix: remove unused import

fix: more waits for nexus 6 in SettingsRobot.kt
@AaronMT AaronMT merged commit 6ac13b3 into mozilla-mobile:master Mar 2, 2020
@AaronMT AaronMT deleted the etp-ui-tests-fix-reenable branch March 2, 2020 20:15
gmierz pushed a commit to gmierz/fenix that referenced this pull request Mar 5, 2020
@liuche liuche mentioned this pull request Mar 12, 2020
32 tasks
@liuche liuche mentioned this pull request Mar 24, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:automation Build automation, Continuous integration, .. eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable and fix ETP UI tests
3 participants