Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] "Share" menu "All Actions" panel does not have correct scroll endpoints #8985

Closed
Cheap-Skate opened this issue Mar 5, 2020 · 3 comments
Closed

[Bug] "Share" menu "All Actions" panel does not have correct scroll endpoints #8985

Cheap-Skate opened this issue Mar 5, 2020 · 3 comments
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Sharing needs:triage Issue needs triage S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist S3 Blocks non-critical functionality and a work around exists

Comments

@Cheap-Skate
Copy link

Cheap-Skate commented Mar 5, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

Open "Share" menu
Scroll "ALL ACTIONS" list left and right
Left end stops correctly and has overscroll crescent
Right end stop does not, half an icon visible, no overscroll crescent
--> incorrect behavior

Device information

  • Android device: Galaxy A40, Android 9.0.0
  • Fenix version: Today's

┆Issue is synchronized with this Jira Task
@Cheap-Skate Cheap-Skate added the 🐞 bug Crashes, Something isn't working, .. label Mar 5, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 5, 2020
@sv-sdeiac
Copy link

sv-sdeiac commented Mar 5, 2020 •
edited
Loading

Hello, I can confirm that the half icon problem is visible using:

  • Nokia 6 (Android 7.1.1) - 1080 x 1920 pixels (~403 ppi pixel density);
  • LG g7 fit (Android 8.1) - 1440 x 3120 pixels, 19.5:9 ratio (~563 ppi density).
  • Xiaomi Mi 8 Lite (Android 9) - 1080 x 2280 pixels, 19:9 ratio (~403 ppi density).

Edit*
The overscroll crescent is not displayed when you have the "Recently used" section displayed on the share options.

It seems that this issue is displayed when the "Recently used" section is displayed on the share panel.

Build: Firefox Preview Nightly 3/5 #20650606.

@sv-sdeiac sv-sdeiac added S3 Blocks non-critical functionality and a work around exists Feature:Sharing labels Mar 5, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Mar 6, 2020

Reproducible on Fenix Beta 4.0.0-beta.4 using a OnePlus A3 (Android 6.0.1) device.
❗️ Some of the apps can't be reached while in portrait mode.

► Video
20200306-135628

@AndiAJ AndiAJ added the S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist label Mar 6, 2020
@mcarare mcarare self-assigned this Mar 6, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Mar 6, 2020
For mozilla-mobile#8985 Fix Share Menu display when having recently u…
7b20e66 
…sed list.

Allow for All Actions recyclerview to scroll to end.
Adjust padding for views.
mcarare pushed a commit to mcarare/fenix that referenced this issue Mar 9, 2020
For mozilla-mobile#8985 Fix Share Menu display when having recently u…
0ad1794 
…sed list.

Allow for All Actions recyclerview to scroll to end.
Adjust padding for views.
ekager pushed a commit that referenced this issue Mar 9, 2020
@ekager
For #8985 Fix Share Menu display when having recently used list.
a581486 
Allow for All Actions recyclerview to scroll to end.
Adjust padding for views.
@ekager ekager added the eng:qa:needed QA Needed label Mar 9, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Mar 10, 2020 •
edited
Loading

Hi, verified as fixed on the latest Nightly Build #20700607 from 03/10 using the following devices:
• Google Pixel 4XL (Android 10)
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

►Video
20200310-104124

@AndiAJ AndiAJ closed this as completed Mar 10, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Mar 10, 2020
@liuche liuche mentioned this issue Mar 12, 2020
Closed
32 tasks
severinrudie pushed a commit to severinrudie/fenix that referenced this issue Mar 18, 2020
@severinrudie
For mozilla-mobile#8985 Fix Share Menu display when having recently u…
b4dcc7c 
…sed list.

Allow for All Actions recyclerview to scroll to end.
Adjust padding for views.
@liuche liuche mentioned this issue Mar 24, 2020
Closed
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Sharing needs:triage Issue needs triage S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist S3 Blocks non-critical functionality and a work around exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ekager @sv-sdeiac @Cheap-Skate @mcarare @AndiAJ