Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]The tab drawer number is not centered when open Top Sites pages #8859

Closed
sv-sdeiac opened this issue Feb 28, 2020 · 5 comments
Closed

[Bug]The tab drawer number is not centered when open Top Sites pages #8859

sv-sdeiac opened this issue Feb 28, 2020 · 5 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Shortcuts Top Sites/Topsites on the Firefox home page needs:triage Issue needs triage S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@sv-sdeiac
Copy link

sv-sdeiac commented Feb 28, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Open the Homepage of the app;
  2. Tap on a Top Site page;
  3. Observe the tab drawer number.

Expected behavior

The number is displayed without any issue.

Actual behavior

The number is not centered.

Device information

  • Android device: Samsung Galaxy Note 8 (Android 9).
  • Fenix version: Firefox Preview Nightly 2/28 #20590606.
    20200228_165903

┆Issue is synchronized with this Jira Task
@sv-sdeiac sv-sdeiac added the 🐞 bug Crashes, Something isn't working, .. label Feb 28, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 28, 2020
@sv-sdeiac sv-sdeiac added Feature:Shortcuts Top Sites/Topsites on the Firefox home page S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Feb 28, 2020
@darkwing
Copy link
Contributor

We should revisit this when @gabrielluong has #8791 ready.

@sblatz
Copy link
Contributor

sblatz commented Feb 28, 2020

This is a pretty annoying visual bug and is not isolated to top sites.

@cadeyrn
Copy link
Contributor

cadeyrn commented Feb 29, 2020

related: #8859.

sblatz added a commit to sblatz/fenix that referenced this issue Mar 3, 2020
@sblatz
For mozilla-mobile#5346 & For mozilla-mobile#8859: Fixes textSize & a…
085c66c 
…nimation on TabCounter
sblatz added a commit to sblatz/fenix that referenced this issue Mar 3, 2020
@sblatz
For mozilla-mobile#5346 & For mozilla-mobile#8859: Fixes textSize & a…
bf7b7c7 
…nimation on TabCounter
sblatz added a commit to sblatz/fenix that referenced this issue Mar 3, 2020
@sblatz
For mozilla-mobile#5346 & For mozilla-mobile#8859: Fixes textSize & a…
f4950f9 
…nimation on TabCounter
sblatz added a commit that referenced this issue Mar 3, 2020
@sblatz
For #5346 & For #8859: Fixes textSize & animation on TabCounter
f20fb50
@sblatz sblatz added the eng:qa:needed QA Needed label Mar 3, 2020
@sv-sdeiac
Copy link
Author

sv-sdeiac commented Mar 3, 2020 •
edited
Loading

Verified as fixed using the latest version of Firefox Preview Nightly 3/3 (#20630607).

Devices:

  • Nokia 6 (Android 7.1.1);
  • Samsung Galaxy Note 8 (Android 9);
  • Google Pixel (Android Q).

@sv-sdeiac sv-sdeiac added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Mar 3, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Mar 4, 2020

Reproducible on Beta 4.0.0-beta.3 using a OnePlus A3 (Android 6.0.1)
► Screenshot
rsz_screenshot_20200304-122217

gmierz pushed a commit to gmierz/fenix that referenced this issue Mar 5, 2020
@sblatz @gmierz
For mozilla-mobile#5346 & For mozilla-mobile#8859: Fixes textSize & a…
c57d2bc 
…nimation on TabCounter
@liuche liuche mentioned this issue Mar 12, 2020
Closed
32 tasks
@liuche liuche mentioned this issue Mar 24, 2020
Closed
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Shortcuts Top Sites/Topsites on the Firefox home page needs:triage Issue needs triage S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@darkwing @cadeyrn @boek @sblatz @sv-sdeiac @AndiAJ