Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Update onboarding cards for post-migration #6980

Closed
4 of 6 tasks
apbitner opened this issue Dec 5, 2019 · 14 comments
Closed
4 of 6 tasks

Update onboarding cards for post-migration #6980

apbitner opened this issue Dec 5, 2019 · 14 comments
Assignees
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:Migration Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR

Comments

@apbitner
Copy link

apbitner commented Dec 5, 2019

User Story

As a new user on the new Fenix/Firefox for Android, I want to see onboarding cards that will help me understand the value of key features, so I know the value I will be getting from using this new browser.

Dependency

Acceptance Criteria

  1. New What's new card
  2. I can choose whether I want strict or standard tracking protection (Re-purpose the existing TP card to surface ETP modes as a user selected option)
  3. I know that I can choose the position of my nav bar when I first start using the browser. Accessibility users will be defaulted to Top nav bar and we will skip this specific onboarding card for this group.
  4. When people click on the FAQ link, it should be similar to what Privacy Policy link does (e.g. "custom tab")
  5. Changes to private browsing copy + adding a link to private browsing settings

UX mocks

┆Issue is synchronized with this Jira Task

@liuche
Copy link
Contributor

liuche commented Jan 14, 2020

Hey @apbitner, just checking in here - are the onboarding cards for this finalized? or are we still waiting on strings, etc. I already see some mocks for these cards https://app.abstract.com/share/b1b9f719-fbb5-4c94-b45d-556232a3cd52 and just wondering if they are ready for eng! If so, could you move it to the Feature Backlog column (or add an eng:ready label)? Thank you!

@apbitner
Copy link
Author

@liuche I'm reviewing with Vesta & design team today so should be able to wrap them up today/tomorrow. Strings for migration UI (not including these onboarding cards) was finalized last week but I'll get the rest reviewed ASAP once the cards are finalized.

@vesta0 vesta0 added the E5 Estimation Point: about 5 days label Jan 14, 2020
@mheubusch
Copy link
Contributor

@mcarare
Copy link
Contributor

mcarare commented Jan 22, 2020

@apbitner @mheubusch

mcarare pushed a commit to mcarare/fenix that referenced this issue Jan 22, 2020
Added test to description.
Added link to settings.
Updated unit tests.
@apbitner
Copy link
Author

@mcarare #6479 is for the settings section. The user will not be able to select 'Custom' from the onboarding card. I'll let @mheubusch weigh in on the copy.

For your second question, "Open settings" should not dismiss onboarding. It should be there when the user returns from settings. I believe the only ways to dismiss onboarding are to run a search or type in a URL, so let's keep that behavior.

mcarare pushed a commit to mcarare/fenix that referenced this issue Jan 27, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Jan 28, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Jan 28, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Feb 7, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Feb 7, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Feb 7, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Feb 10, 2020
Added test to description.
Added link to settings.
Updated unit tests.
@ekager ekager added eng:qa:needed QA Needed and removed eng:qa:needed QA Needed labels Feb 10, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Feb 10, 2020
Added test to description.
Added link to settings.
Updated unit tests.
mcarare pushed a commit to mcarare/fenix that referenced this issue Feb 10, 2020
Added test to description.
Added link to settings.
Updated unit tests.
mcarare pushed a commit to mcarare/fenix that referenced this issue Feb 10, 2020
Added test to description.
Added link to settings.
Updated unit tests.
mcarare pushed a commit to mcarare/fenix that referenced this issue Feb 12, 2020
Added test to description.
Added link to settings.
Updated unit tests.
mcarare pushed a commit to mcarare/fenix that referenced this issue Feb 12, 2020
Added test to description.
Added link to settings.
Updated unit tests.
mcarare pushed a commit to mcarare/fenix that referenced this issue Feb 12, 2020
Added test to description.
Added link to settings.
Updated unit tests.
boek pushed a commit to mcarare/fenix that referenced this issue Feb 12, 2020
Added test to description.
Added link to settings.
Updated unit tests.
mcarare pushed a commit to mcarare/fenix that referenced this issue Feb 13, 2020
Added test to description.
Added link to settings.
Updated unit tests.
boek pushed a commit that referenced this issue Feb 13, 2020
Added test to description.
Added link to settings.
Updated unit tests.
@boek boek added the eng:qa:needed QA Needed label Feb 13, 2020
@sv-ohorvath
Copy link
Contributor

Verified as fixed on Nightly 2/18. The only issue found: #8481 - not sure if that was intentional, but I couldn't find an issue related to that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:Migration Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR
Projects
None yet
Development

No branches or pull requests

10 participants