Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

For #8356 - Speculative fix for BrowserGestureDetector IAE #8357

Merged
merged 1 commit into from
Sep 11, 2020
Merged

For #8356 - Speculative fix for BrowserGestureDetector IAE #8357

merged 1 commit into from
Sep 11, 2020

Conversation

Mugurell
Copy link
Contributor

@Mugurell Mugurell commented Sep 9, 2020

Try to resolve a situation in which system's GestureDetector calls us as a
callback with null parameters, so triggering an IllegalArgumentException.
A possible explanation could be that not all MotionEvents are passed to the
GestureDetector, situation which this patch tries to fix.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includesor does not need one.
  • Accessibility: The code in this PR does not include any user facing features.

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@Mugurell Mugurell requested a review from pocmo September 9, 2020 09:48
@Mugurell
For mozilla-mobile#8356 - Speculative fix for BrowserGestureDetector IAE
ca028ae 
Try to resolve a situation in which system's GestureDetector calls us as a
callback with null parameters, so triggering an IllegalArgumentException.
A possible explanation could be that not all MotionEvents are passed to the
GestureDetector, situation which this patch tries to fix.
@Amejia481 Amejia481 added the 🕵️‍♀️ needs review PRs that need to be reviewed label Sep 10, 2020
pocmo
pocmo approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@pocmo pocmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link

bors bot commented Sep 11, 2020

Build succeeded:

@bors bors bot merged commit f93ad41 into mozilla-mobile:master Sep 11, 2020
@Mugurell Mugurell deleted the gestureDetectorNPE branch September 11, 2020 11:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pocmo pocmo pocmo approved these changes

Assignees

@pocmo pocmo

Labels
🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mugurell @pocmo @Amejia481