Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes #3864: Make text size of minus and plus buttons have the same size on reader view #3860

Merged
merged 2 commits into from
Jul 23, 2019
Merged

Closes #3864: Make text size of minus and plus buttons have the same size on reader view #3860

merged 2 commits into from
Jul 23, 2019

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Jul 23, 2019 •
edited by Amejia481
Loading

changed "sans-serif" textsize to match "serif"
changed sign used from h'yphen-minus' to true 'minus'

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.

@mcarare mcarare requested a review from a team as a code owner July 23, 2019 08:34
Amejia481
Amejia481 approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mihai-Adrian 👍

@Amejia481 Amejia481 added 🛬 needs landing PRs that are ready to land blocked Blocked pull requests and issues and removed 🛬 needs landing PRs that are ready to land labels Jul 23, 2019
@Amejia481 Amejia481 changed the title fixes #3121 on fenix - Text size and font aren't equal in Reader mode Closes: #3864 on fenix - Text size and font aren't equal in Reader mode Jul 23, 2019
@Amejia481 Amejia481 changed the title Closes: #3864 on fenix - Text size and font aren't equal in Reader mode Closes #3864: Make text size of minus and plus buttons have the same size on reader view Jul 23, 2019
@Amejia481 Amejia481 added 🛬 needs landing PRs that are ready to land and removed blocked Blocked pull requests and issues labels Jul 23, 2019
@Amejia481
Copy link
Contributor

Amejia481 commented Jul 23, 2019 •
edited
Loading

@Mihai-Adrian Before merging, I did some minimal changes.

@pocmo pocmo merged commit 49561cd into mozilla-mobile:master Jul 23, 2019
@mcarare mcarare deleted the 3121 branch December 17, 2019 08:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Amejia481 Amejia481 Amejia481 approved these changes

Assignees
No one assigned
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcarare @Amejia481 @pocmo