Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add baidu search ad telemetry #11582

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

rxumoz
Copy link
Contributor

@rxumoz rxumoz commented Jan 20, 2022

Add the extraAdServersRegexps of Baidu to help sending the baidu search telemetry of ads.

Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think would be good if we add the issue number to the commit title for example "Closes #11582 Add baidu search ad telemetry", additionally we could add a entry to the changelog file indicating this change, here there is an example were we do that.

rxumoz added a commit to MozillaOnline/android-components that referenced this pull request Jan 21, 2022
rxumoz added a commit to MozillaOnline/android-components that referenced this pull request Jan 21, 2022
@rxumoz
Copy link
Contributor Author

rxumoz commented Jan 21, 2022

I'm not authorized to label, anyone can help to merge? Thx!

@mergify
Copy link
Contributor

mergify bot commented Jan 21, 2022

This pull request has conflicts when rebasing. Could you fix it @rxumoz? 🙏

@Amejia481 Amejia481 added the 🛬 needs landing PRs that are ready to land label Jan 21, 2022
@Amejia481
Copy link
Contributor

I'm not authorized to label, anyone can help to merge? Thx!

No problem, I updated the PR with the label for landing

@mergify mergify bot merged commit 23752ef into mozilla-mobile:main Jan 24, 2022
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this pull request Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants