Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Stop logging places reads/writes interrupts #12557

Closed
Mugurell opened this issue Jul 28, 2022 · 0 comments · Fixed by #12558 or nathanmkaya/android-components#362
Closed

Stop logging places reads/writes interrupts #12557

Mugurell opened this issue Jul 28, 2022 · 0 comments · Fixed by #12558 or nathanmkaya/android-components#362
Assignees
@Mugurell
Milestone
105.0.0 🫥

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Jul 28, 2022 •
edited by data-sync-user
Loading

#12469 added an explicit interruptcall before querying new suggestions from AS.
As the interrupt call is set to throw an PlacesException.OperationInterrupted exception it also added logging that similar to how other places calls are handled.
In hindsight this was expected to spam the crash servers with reports of little use.
We should stop logging this particular exception which is expected to happen quite frequently.

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell self-assigned this Jul 28, 2022
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 28, 2022
@Mugurell
For mozilla-mobile#12557 - Stop logging AS-places reads/writes explic…
32aaf52 
…it interrupts

The OperationInterrupted exceptions are expected so logging them to the crash
servers has little use.
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 28, 2022
@Mugurell
For mozilla-mobile#12557 - Stop logging AS-places reads/writes explic…
000daca 
…it interrupts

The OperationInterrupted exceptions are expected so logging them to the crash
servers has little use.
@github-actions github-actions bot mentioned this issue Jul 28, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #12558 Jul 28, 2022
mergify bot pushed a commit that referenced this issue Jul 28, 2022
@Mugurell @mergify
For #12557 - Stop logging AS-places reads/writes explicit interrupts
0ed5dfb 
The OperationInterrupted exceptions are expected so logging them to the crash
servers has little use.
@github-actions github-actions bot added this to the 105.0.0 🫥 milestone Jul 28, 2022
mergify bot pushed a commit that referenced this issue Jul 28, 2022
@Mugurell @mergify
For #12557 - Stop logging AS-places reads/writes explicit interrupts
22a90a1 
The OperationInterrupted exceptions are expected so logging them to the crash
servers has little use.

(cherry picked from commit 0ed5dfb)

# Conflicts:
#	docs/changelog.md
Mugurell added a commit that referenced this issue Jul 28, 2022
@Mugurell
For #12557 - Stop logging AS-places reads/writes explicit interrupts
31f4eb7 
The OperationInterrupted exceptions are expected so logging them to the crash
servers has little use.

(cherry picked from commit 0ed5dfb)
mergify bot pushed a commit that referenced this issue Jul 28, 2022
@Mugurell @mergify
For #12557 - Stop logging AS-places reads/writes explicit interrupts
4ea7ba2 
The OperationInterrupted exceptions are expected so logging them to the crash
servers has little use.

(cherry picked from commit 0ed5dfb)
@github-actions github-actions bot mentioned this issue Oct 1, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
None yet
Projects
None yet
Milestone
105.0.0 🫥
1 participant
@Mugurell