Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Consider custom tabs when setting orientation through MediaSessionFullscreenFeature #12298

Closed
Mugurell opened this issue Jun 7, 2022 · 2 comments · Fixed by #12288
Closed

Consider custom tabs when setting orientation through MediaSessionFullscreenFeature #12298

Mugurell opened this issue Jun 7, 2022 · 2 comments · Fixed by #12288
Assignees
@indurs
Labels
<customtabs> Component: feature-customtabs <media> Component: feature-media

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Jun 7, 2022 •
edited by data-sync-user
Loading

AC integrators have a bug with a custom tab opened while the app in in Picture-In-Picture mode having an unexpected landscape orientation - mozilla-mobile/fenix#25413

@indurs saw that we need to support custom tabs in MediaSessionFullscreenFeature to fix this issue - #12288

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell added <customtabs> Component: feature-customtabs <media> Component: feature-media labels Jun 7, 2022
@indurs
Copy link
Contributor

indurs commented Jun 8, 2022

@Mugurell , shall I change the commit title of the PR #12288 to this issue#?

indurs added a commit to indurs/android-components that referenced this issue Jun 8, 2022
@indurs @Mugurell
For mozilla-mobile#12298: App should not be locked in landscape when …
8c555ff 
…a tab or custom tab loads while in pip mode

This allows a tab or custom tab to be loaded in device's current orientation while pip mode is active

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
@Mugurell
Copy link
Contributor Author

Mugurell commented Jun 9, 2022

@Mugurell , shall I change the commit title of the PR #12288 to this issue#?

Thank you for going ahead and updating. Indeed all PRs in a project should link to an issue existing in that same project offering more context about the needed changes.

Mugurell added a commit to Mugurell/android-components that referenced this issue Jun 9, 2022
@indurs @Mugurell
For mozilla-mobile#12298: App should not be locked in landscape when …
a968b40 
…a tab or custom tab loads while in pip mode

This allows a tab or custom tab to be loaded in device's current orientation while pip mode is active

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
mergify bot pushed a commit that referenced this issue Jun 9, 2022
@indurs @Mugurell @mergify
For #12298: App should not be locked in landscape when a tab or custo…
c3b680a 
…m tab loads while in pip mode

This allows a tab or custom tab to be loaded in device's current orientation while pip mode is active

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
@gabrielluong gabrielluong mentioned this issue Oct 19, 2022
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@indurs indurs

Labels
<customtabs> Component: feature-customtabs <media> Component: feature-media
Projects
None yet
Milestone
No milestone
3 participants
@gabrielluong @Mugurell @indurs