Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Use delegates for Login and Credit card pickers in PromptFeature #12257

Closed
Alexandru2909 opened this issue May 31, 2022 · 1 comment · Fixed by #12272
Closed

Use delegates for Login and Credit card pickers in PromptFeature #12257

Alexandru2909 opened this issue May 31, 2022 · 1 comment · Fixed by #12272
Assignees
@Alexandru2909
Labels
⌨️ code Technical debt, code clean up, small API change ..

Comments

@Alexandru2909
Copy link
Contributor

Alexandru2909 commented May 31, 2022 •
edited by data-sync-user
Loading

To decrease the long parameter list's size, we should use the delegate pattern for Login and Credit card pickers and their related callbacks, similar to shareDelegate.

┆Issue is synchronized with this Jira Task
@Alexandru2909 Alexandru2909 added the ⌨️ code Technical debt, code clean up, small API change .. label May 31, 2022
@Alexandru2909 Alexandru2909 self-assigned this May 31, 2022
@Alexandru2909 Alexandru2909 mentioned this issue May 31, 2022
Merged
4 tasks
@jonalmeida
Copy link
Contributor

jonalmeida commented May 31, 2022 •
edited
Loading

See also: #10323 and #8192

Alexandru2909 pushed a commit to Alexandru2909/android-components that referenced this issue Jun 2, 2022
For mozilla-mobile#12257 - Add LoginDelegate and CreditCardDelegate t…
706e665 
…o replace PromptFeature parameters
Alexandru2909 pushed a commit to Alexandru2909/android-components that referenced this issue Jun 2, 2022
For mozilla-mobile#12257 - Add LoginDelegate and CreditCardDelegate t…
c27cefd 
…o replace PromptFeature parameters
Alexandru2909 pushed a commit to Alexandru2909/android-components that referenced this issue Jun 14, 2022
For mozilla-mobile#12257 - Add LoginDelegate and CreditCardDelegate t…
4289405 
…o replace PromptFeature parameters
Alexandru2909 pushed a commit to Alexandru2909/android-components that referenced this issue Jun 15, 2022
For mozilla-mobile#12257 - Add LoginDelegate and CreditCardDelegate t…
3c6c13c 
…o replace PromptFeature parameters
@Alexandru2909 Alexandru2909 mentioned this issue Jun 15, 2022
Closed
mergify bot pushed a commit that referenced this issue Jun 15, 2022
@mergify
For #12257 - Add LoginDelegate and CreditCardDelegate to replace Prom…
bae083e 
…ptFeature parameters
@jonalmeida jonalmeida linked a pull request Jun 23, 2022 that will close this issue
For #12257 - Add LoginDelegate and CreditCardDelegate to replace PromptFeature parameters #12272
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Alexandru2909 Alexandru2909

Labels
⌨️ code Technical debt, code clean up, small API change ..
Projects
None yet
Milestone
No milestone
2 participants
@jonalmeida @Alexandru2909