This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
BrowserMenu - endOfMenuAlwaysVisible = true has no effect
#10005
Assignees
Milestone
Comments
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Apr 1, 2021
…ge stackFromEnd The `stackFromEnd` property is not initially set even though `endOfMenuAlwaysVisible` might be true since when having a bottom expandable menu, that should always be scrolled to the top. And we know if we're in that situation only later, after menu is configured and based on it it can be inferred if it should be collapsed or not. Setting `stackFromEnd` only after this steps, even if the menu is not yet on the screen seems to have no effect. The only solution is to replace menu's layout manager with one that has this `stackFromEnd` from the beginning.
4 tasks
4 tasks
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Apr 6, 2021
…ge stackFromEnd The `stackFromEnd` property is not initially set even though `endOfMenuAlwaysVisible` might be true since when having a bottom expandable menu, that should always be scrolled to the top. And we know if we're in that situation only later, after menu is configured and based on it it can be inferred if it should be collapsed or not. Setting `stackFromEnd` only after this steps, even if the menu is not yet on the screen seems to have no effect. The only solution is to replace menu's layout manager with one that has this `stackFromEnd` from the beginning.
mergify bot
pushed a commit
that referenced
this issue
Apr 6, 2021
The `stackFromEnd` property is not initially set even though `endOfMenuAlwaysVisible` might be true since when having a bottom expandable menu, that should always be scrolled to the top. And we know if we're in that situation only later, after menu is configured and based on it it can be inferred if it should be collapsed or not. Setting `stackFromEnd` only after this steps, even if the menu is not yet on the screen seems to have no effect. The only solution is to replace menu's layout manager with one that has this `stackFromEnd` from the beginning.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is a regression from #9879 which still uses this
endOfMenuAlwaysVisibleproperty but sets it at a later time and seemingly it is too late for it to have an effect.This was the true cause of some UI tests failing here - mozilla-mobile/fenix#18619 where @sv-ohorvath saw that the menu looks to have different options because it is not scrolled to the bottom anymore.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: