-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Servo] Remove soon-to-be obsolete functions #2175
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2175 +/- ##
==========================================
+ Coverage 50.47% 50.54% +0.07%
==========================================
Files 387 387
Lines 31790 31719 -71
==========================================
- Hits 16043 16028 -15
+ Misses 15747 15691 -56
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to clean this up too:
test/servo_launch_test_common.hpp:#include <moveit_msgs/srv/change_drift_dimensions.hpp>
test/servo_launch_test_common.hpp:#include <moveit_msgs/srv/change_control_dimensions.hpp>
test/servo_launch_test_common.hpp: resolveServoTopicName("~/change_control_dimensions"));
test/servo_launch_test_common.hpp: resolveServoTopicName("~/change_drift_dimensions"));
fe2831f
to
b0bb725
Compare
@sjahr I think this can be merged now |
Description
This PR removes the following functionalities and related code from
ServoCalcs
as they will be made obsolete by better support in IK solver through cost functions.Checklist