Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back withdraw and deposit logic #84

Merged
merged 7 commits into from
Sep 22, 2023
Merged

Conversation

MerlinEgalite
Copy link
Contributor

@MerlinEgalite MerlinEgalite commented Sep 20, 2023

Roll back changes in this PR.

Pros:

  • less lines of code
  • ease audits

Cons:

  • errors issue (to investigate more)

@MerlinEgalite MerlinEgalite requested review from a team, Rubilmax and Jean-Grimal and removed request for a team September 20, 2023 10:07
@MerlinEgalite MerlinEgalite changed the title [WIP] Roll back withdraw and deposit logic Roll back withdraw and deposit logic Sep 20, 2023
@MerlinEgalite MerlinEgalite marked this pull request as ready for review September 20, 2023 12:24
test/forge/ERC4626Test.sol Outdated Show resolved Hide resolved
src/MetaMorpho.sol Outdated Show resolved Hide resolved
Co-authored-by: Romain Milon <rmilon@gmail.com>
Signed-off-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com>
src/MetaMorpho.sol Outdated Show resolved Hide resolved
@MerlinEgalite MerlinEgalite merged commit 54123ca into main Sep 22, 2023
6 checks passed
@MerlinEgalite MerlinEgalite deleted the refactor/withdraw-deposit branch September 22, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants