-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/queue revamp #71
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 18, 2023
Closed
Closed
Jean-Grimal
reviewed
Sep 19, 2023
Jean-Grimal
reviewed
Sep 19, 2023
Jean-Grimal
reviewed
Sep 19, 2023
Jean-Grimal
reviewed
Sep 19, 2023
Jean-Grimal
reviewed
Sep 19, 2023
Jean-Grimal
reviewed
Sep 19, 2023
…into feat/queue-revamp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review but nice job!
Jean-Grimal
approved these changes
Sep 19, 2023
MerlinEgalite
requested changes
Sep 19, 2023
Jean-Grimal
reviewed
Sep 19, 2023
Closed
MerlinEgalite
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the latest specs on supply/withdraw queues. It relies on some definitions and invariants to verify execution is correct:
Definitions
Invariants
supplyQueue
stores any queue of markets: if the market has a zero cap, it is skipped ; if it doesn't, it is enabled and thus supplied towithdrawQueue
only stores enabled markets and always stores them allInvariant 2 is verified thanks to the way markets are enabled and the way the withdraw queue is managed:
withdrawQueue
always contains all enabled marketsI let the reviewer prove that "changing the order of the withdraw queue is only performed via a permutation of enabled markets"!
Gas diff
submitMarket
+enableMarket
= 350k)submitCap
+acceptCap
if timelock = 122k)disableMarket
(not tested)submitCap(0)
(122k)