Fix deposit fee #38
Merged
Fix deposit fee #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add timelock
…morpho-blue-metamorpho into fix/deposit-fee
Rubilmax
force-pushed
the
fix/deposit-fee
branch
3 times, most recently
from
3ae1742
to
09bf26a
Compare
Rubilmax
force-pushed
the
fix/deposit-fee
branch
from
09bf26a
to
fc73b4c
Compare
…rpho into fix/deposit-fee
Closed
MerlinEgalite
approved these changes
Sep 12, 2023
| modifier syncLastTotalAssets() { | ||
| _; | ||
|
|
||
| lastTotalAssets = totalAssets(); |
There was a problem hiding this comment.
Now we trigger 2 times totalAssets for each tx. It will cost a lot...
There was a problem hiding this comment.
Unfortunately, it is the only viable solution. Using a timestamp-based solution creates a bug: if 2 users deposit within the same block, lastTotalAssets is not updated with the last user's deposit, which gets counted as interest in the next fee accrual...
There was a problem hiding this comment.
I just pushed an alternative version that saves 2 calls to totalAssets. This should be a huge gas cost improvement
MerlinEgalite
approved these changes
Sep 12, 2023
Rubilmax
force-pushed
the
fix/deposit-fee
branch
from
c4f76b4
to
f058644
Compare
MerlinEgalite
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests break because they are incomplete: in order for the fee recipient to accrue fee, the vault must realize a performance (it should actually not accrue fee from deposits/withdrawals)