Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(metamorpho): comment forced market removal #354

Merged
merged 11 commits into from
Dec 28, 2023
Merged

docs(metamorpho): comment forced market removal #354

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d33b866
docs(metamorpho): comment forced market removal
Rubilmax Dec 18, 2023
0df88ed
docs(metamorpho): clearer explain
Rubilmax Dec 22, 2023
0f64b92
fix(metamorpho): accrue fee on reallocate
Rubilmax Dec 22, 2023
aeb7ac1
fix(reallocate): prevent withdrawing from not enabled market
Rubilmax Dec 22, 2023
dd781a3
test(reallocate): add market not enabled
Rubilmax Dec 22, 2023
fa51084
Merge branch 'post-cantina' into docs/edge-case
MathisGD Dec 26, 2023
44fe10d
docs: apply suggestion
MerlinEgalite Dec 27, 2023
03b71d6
Merge branch 'post-cantina' of github.com:morpho-org/metamorpho into …
Rubilmax Dec 27, 2023
7a36d23
docs(market-removal): remove incorrect comment
Rubilmax Dec 27, 2023
39ccc2b
Merge branch 'fix/reallocate-donation' of github.com:morpho-org/metam…
Rubilmax Dec 27, 2023
49f0616
docs(market-removal): recover back
Rubilmax Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/interfaces/IMetaMorpho.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,12 @@ interface IMetaMorphoBase {
/// @notice Revokes the pending cap of the market defined by `id`.
function revokePendingCap(Id id) external;

/// @notice Submits a forced market removal from the vault, potentially losing all funds supplied to the market.
/// @notice Submits a forced market removal from the vault, losing all funds supplied to the market.
Rubilmax marked this conversation as resolved.
Show resolved Hide resolved
Rubilmax marked this conversation as resolved.
Show resolved Hide resolved
/// @notice This forced removal is expected to be used as an emergency process in case a market constantly reverts.
/// To softly remove a sane market, the curator role is expected to bundle a reallocation that empties the market
/// first (using `reallocate`), followed by the removal of the market (using `updateWithdrawQueue`).
/// @dev Warning: Submitting a forced removal will overwrite the timestamp at which the market will be removable.
Rubilmax marked this conversation as resolved.
Show resolved Hide resolved
/// @dev Warning: Removing a market with non-zero supply will instantly impact the vault's price per share.
MathisGD marked this conversation as resolved.
Show resolved Hide resolved
function submitMarketRemoval(Id id) external;

/// @notice Revokes the pending removal of the market defined by `id`.
Expand Down