Fix _withdraw() natspec #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean-Grimal
requested review from
a team,
adhusson,
Rubilmax,
QGarchery,
MerlinEgalite and
MathisGD
and removed request for
a team
Rubilmax
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Ideally we also update the test testWithdrawMoreThanTotalAssets which expects to revert with NotEnoughLiquidity whereas it should revert either with an ERC4626 error or an underflow
But for now it reverts with NotEnoughLiquidity because Blue doesn't have enough liquidity. We should make so another supplier provides enough liquidity on Blue
testWithdrawMoreThanBalanceButLessThanLiquidity should also be renamed testWithdrawMoreThanBalanceAndLiquidity
Rubilmax
previously approved these changes
Dec 13, 2023
MerlinEgalite
approved these changes
Dec 13, 2023
MerlinEgalite
previously approved these changes
Dec 13, 2023
adhusson
previously approved these changes
Dec 18, 2023
QGarchery
previously approved these changes
Dec 22, 2023
Jean-Grimal
dismissed stale reviews from QGarchery, adhusson, MerlinEgalite, and Rubilmax
via
f8faed7
Co-authored-by: Quentin Garchery <QGarchery@users.noreply.github.com> Signed-off-by: Jean-Grimal <83286814+Jean-Grimal@users.noreply.github.com>
Rubilmax
suggested changes
Dec 22, 2023
Rubilmax
approved these changes
Dec 22, 2023
MerlinEgalite
approved these changes
Dec 22, 2023
QGarchery
approved these changes
Dec 22, 2023
MathisGD
reviewed
Dec 26, 2023
MathisGD
approved these changes
Dec 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://cantina.xyz/code/8409a0ce-6c21-4cc9-8ef2-bd77ce7425af/findings/637922bd-c38b-4ea0-bb51-a1420a47d088