Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning override/delete pending values #232

Merged
merged 6 commits into from
Oct 20, 2023

Conversation

MerlinEgalite
Copy link
Contributor

Fixes #221

@MerlinEgalite MerlinEgalite requested review from QGarchery, a team, Rubilmax and Jean-Grimal and removed request for a team October 19, 2023 13:45
src/MetaMorpho.sol Outdated Show resolved Hide resolved
Copy link
Contributor

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with only needing a comment to fix this, I put the explanation in the related issue #221

@MerlinEgalite
Copy link
Contributor Author

@QGarchery do you block adding the comment still?

@MerlinEgalite
Copy link
Contributor Author

Merging this PR, @QGarchery feel free to reopen #221

@MerlinEgalite MerlinEgalite merged commit 80b56e2 into main Oct 20, 2023
4 checks passed
@MerlinEgalite MerlinEgalite deleted the docs/remove-pending-values branch October 20, 2023 17:57
@MerlinEgalite MerlinEgalite restored the docs/remove-pending-values branch October 20, 2023 17:58
@MerlinEgalite MerlinEgalite deleted the docs/remove-pending-values branch October 20, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[protocol review] Possible accidental removal of pending transactions
4 participants