Fix static withdraw #205
Merged
Fix static withdraw #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MerlinEgalite
requested review from
a team,
Rubilmax and
Jean-Grimal
and removed request for
a team
MerlinEgalite
commented
Oct 13, 2023
test/forge/InternalTest.sol
Outdated
| @@ -169,4 +169,34 @@ contract InternalTest is Test, MetaMorpho { | |||
|
|
|||
| assertEq(withdrawable, expectedWithdrawable, "withdrawable"); | |||
| } | |||
|
|
|||
| function testStaticWithdraw(uint256 suppliedAmount, uint256 amountBorrowed, uint256 assets) public { | |||
There was a problem hiding this comment.
Maybe we should do those tests on several markets
|
Oh yes that's the bug I spotted on withdraw while writing BTT. I forgot to fix it in static withdraw as well |
Jean-Grimal
approved these changes
Oct 13, 2023
Are you referring to #142? |
Rubilmax
approved these changes
Oct 16, 2023
Rubilmax
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indeed there was a bug
Fixes #203