Fix last total assets #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MerlinEgalite
requested review from
a team,
Rubilmax and
Jean-Grimal
and removed request for
a team
|
I'm not convinced it's the best solution, there may be something to do with return values of Morpho.supply |
I tried to think about it but Morpho.supply does return the value with the rounding unfortunately. Another option is to query the balance after each deposit but then it requires to use our own |
…blue-metamorpho into fix/last-total-assets
Rubilmax
suggested changes
Oct 17, 2023
Rubilmax
approved these changes
Oct 18, 2023
Jean-Grimal
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198