Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(guardian): add guardian tests #157

Merged
merged 9 commits into from
Oct 6, 2023
Merged

test(guardian): add guardian tests #157

merged 9 commits into from
Oct 6, 2023

Conversation

Rubilmax
Copy link
Contributor

@Rubilmax Rubilmax commented Oct 5, 2023

@Rubilmax Rubilmax marked this pull request as ready for review October 5, 2023 15:26
Jean-Grimal
Jean-Grimal approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@Jean-Grimal Jean-Grimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only revoke guardian is missing, but besides that it is complete

@Rubilmax
Copy link
Contributor Author

Rubilmax commented Oct 5, 2023

Only revoke guardian is missing, but besides that it is complete

I think I added it while you were reviewing, thanks!

MerlinEgalite
MerlinEgalite requested changes Oct 5, 2023
View reviewed changes
test/forge/TimelockTest.sol Outdated Show resolved Hide resolved
test/forge/TimelockTest.sol Show resolved Hide resolved
test/forge/TimelockTest.sol Show resolved Hide resolved
test/forge/GuardianTest.sol Outdated Show resolved Hide resolved
test/forge/GuardianTest.sol Outdated Show resolved Hide resolved
@Rubilmax Rubilmax mentioned this pull request Oct 5, 2023
Closed
@MerlinEgalite
Copy link
Contributor

Conflicts to update

@openzeppelin-code
Copy link

openzeppelin-code bot commented Oct 6, 2023 •
edited
Loading

test(guardian): add guardian tests

Generated at commit: a3c0c90ac539b43ccbe05cd53935995ba718d1c4

🚨 Vulnerabilities Summary

Process Issues Results
Contract Inspector note
low
Total		 16
6
22
Dependency Checker Total 0

For more details view the full report in OpenZeppelin Code

@Rubilmax Rubilmax merged commit 7ca5735 into main Oct 6, 2023
6 checks passed
@Rubilmax Rubilmax deleted the test/guardian branch October 6, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Rubilmax @MerlinEgalite @Jean-Grimal