Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate shared subscription and closed connection if not valid #795

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

andsel
Copy link
Collaborator

@andsel andsel commented Nov 18, 2023

What does this PR do?

During the processing of an MQTT5 SUBSCRIBE message search all topicFilters for shared subscriptions and check for validity respect to specs [MQTT-4.8.2-1] [MQTT-4.8.2-1]

Why is it important/What is the impact to the user?

Part of shared subscription implementation #791

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works
  • [ ] I have updated the Changelog if it's a feature or a fix that has to be reported

@andsel andsel self-assigned this Nov 18, 2023
@andsel andsel mentioned this pull request Nov 18, 2023
6 tasks
@andsel andsel merged commit 39b1688 into moquette-io:main Nov 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant