fix(preview): Fix preview template to take theme template into account #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welcoMattic
requested review from
delyriand,
lanfisis,
maximehuran and
etienne-monsieurbiz
maximehuran
approved these changes
Oct 1, 2024
delyriand
approved these changes
Oct 2, 2024
maximehuran
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preview feature doesn't pay attention to theme template until now. This PR change the base template of the preview template to extend the
@MonsieurBizSyliusCmsPagePlugin/Shop/Page/show.html.twigfile which can be overrided by a theme. As before, we still inject the red banner to warn the user that the current page is displayed in the preview mode.Before, with a custom theme enabled
After, with a custom theme enabled