Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call correctly decorated service with splat argument #53

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Call correctly decorated service with splat argument #53

merged 2 commits into from
Sep 6, 2023

Conversation

maximehuran
Copy link
Member

@maximehuran maximehuran commented Sep 6, 2023 •
edited
Loading

Avoid error like this :

MonsieurBiz\SyliusCmsPagePlugin\Routing\RequestContext::checkPageSlug(): Argument #1 ($request) must be of type Symfony\Component\HttpFoundation\Request, array given, called in /apps/sylius/vendor/monsieurbiz/sylius-no-commerce-plugin/src/Routing/NoCommerceRequestContext.php on line 60

@madamebiz madamebiz added the quick win Easy to pick, everybody will be happy. label Sep 6, 2023
@madamebiz madamebiz added the Status: needs review Status: needs review label Sep 6, 2023
@maximehuran maximehuran merged commit 92168de into monsieurbiz:master Sep 6, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delyriand delyriand delyriand approved these changes

@etienne-monsieurbiz etienne-monsieurbiz etienne-monsieurbiz approved these changes

@lanfisis lanfisis Awaiting requested review from lanfisis

Assignees
No one assigned
Labels
quick win Easy to pick, everybody will be happy. Status: needs review Status: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximehuran @delyriand @etienne-monsieurbiz @madamebiz