GODRIVER-3249: Handle all possible OIDC configuration errors #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matt Dale <9760375+matthewdale@users.noreply.github.com>
API Change Report./x/mongo/driver/authcompatible changesAllowedHostsProp: added |
pmeredit
commented
Aug 6, 2024
| @@ -26,14 +26,24 @@ import ( | |||
| // MongoDBOIDC is the string constant for the MONGODB-OIDC authentication mechanism. | |||
There was a problem hiding this comment.
These are now public so they can be reused in configuration error checking to keep consistency if we ever need to change the values.
…was already doing the right thing
|
I added in GODRIVER-3226 because the GODRIVER was actually handling this correctly, unlike the python driver, and all I needed was to add tests showing that. |
Co-authored-by: Matt Dale <9760375+matthewdale@users.noreply.github.com>
blink1073
pushed a commit
to blink1073/mongo-go-driver
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3249
Summary
Add configuration errors for all malformed configuration for the OIDC authentication mechanism. Some of these are redundant with errors thrown by the OIDC code itself, but these should occur before that point. I think double checking is fine.
Background & Motivation
OIDC epic