GODRIVER-3018 Use pre-commit for development #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
requested review from
prestonvasquez
and removed request for
a team
API Change ReportNo changes found! |
internal/assert/assertions_test.go
Outdated
| @@ -1064,7 +1064,6 @@ Diff: | |||
| @@ -1,2 +1,2 @@ | |||
| -(time.Time) 2020-09-24 00:00:00 +0000 UTC | |||
| +(time.Time) 2020-09-25 00:00:00 +0000 UTC | |||
|
|
|||
There was a problem hiding this comment.
This test appears to expect this blank like: https://parsley.mongodb.com/test/mongo_go_driver_v1_tests_42_plus_zlib_zstd_support__version~7.0_os_ssl_40~rhel87_64_go_1_20_test_replicaset_auth_nossl_patch_3a07cb190cee239b59795758a6f26898cb8cb78d_654105853e8e86b87f9395c1_23_10_31_13_47_51/0/125d94d8de41dfe15df278447d79190a?bookmarks=0,10711,24230&shareLine=10713
There was a problem hiding this comment.
Thanks, I'll play with the whitespace settings.
prestonvasquez
approved these changes
Oct 31, 2023
blink1073
added a commit
to blink1073/mongo-go-driver
that referenced
this pull request
Oct 31, 2023
(cherry picked from commit b8004e6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3018
Summary
Use pre-commit to lint source and text files.
Background & Motivation
Prevent common mistakes and make PR review easier.