chore: add alpine based docker images #39
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| FROM rust:alpine AS builder | ||
| WORKDIR app | ||
|
|
||
| RUN apk add --no-cache musl-dev openssl-dev openssl-libs-static sqlite-dev sqlite-static | ||
|
|
||
| # First build dependencies, this should cache a dependency layer which | ||
| # only needs to be refreshed when Cargo.(lock|toml) is updated | ||
| COPY Cargo.lock Cargo.toml ./ | ||
| RUN mkdir src && echo "fn main() { panic!(\"why am i running?\") }" > src/main.rs | ||
| RUN cargo build --release --locked | ||
|
There was a problem hiding this comment. Also note I added Personally I feel explicitly updating dependencies is always better, especially because the current build workflows don't have a test stage first. For easier maintenance it could require an additional github workflow to help maintaining dependency updates (fe using https://github.com/marketplace/actions/dependencies-autoupdate) |
||
| RUN rm ./src/main.rs && rmdir ./src | ||
|
|
||
| COPY . . | ||
| RUN cargo build --release --locked --bin mollysocket | ||
|
|
||
|
|
||
| FROM alpine:3 AS runtime | ||
| WORKDIR app | ||
|
|
||
| ENV MOLLY_HOST=127.0.0.1 | ||
| ENV MOLLY_PORT=8020 | ||
|
|
||
| RUN apk add --no-cache ca-certificates | ||
|
|
||
| COPY --from=builder /app/target/release/mollysocket /usr/local/bin/ | ||
| HEALTHCHECK --interval=1m --timeout=3s \ | ||
| CMD wget -q --tries=1 "http://$MOLLY_HOST:$MOLLY_PORT/" -O - | grep '"mollysocket":{"version":' | ||
| ENTRYPOINT ["/usr/local/bin/mollysocket"] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| FROM docker.io/rust:bookworm AS builder | ||
| WORKDIR app | ||
|
|
||
| # First build dependencies, this should cache a dependency layer which | ||
| # only needs to be refreshed when Cargo.(lock|toml) is updated | ||
| COPY Cargo.lock Cargo.toml ./ | ||
| RUN mkdir src && echo "fn main() { panic!(\"why am i running?\") }" > src/main.rs | ||
| RUN cargo build --release --locked | ||
| RUN rm ./src/main.rs && rmdir ./src | ||
|
|
||
| COPY . . | ||
| RUN cargo build --release --locked --bin mollysocket | ||
|
|
||
|
|
||
| FROM docker.io/debian:bookworm-slim AS runtime | ||
| WORKDIR app | ||
|
|
||
| ENV MOLLY_HOST=127.0.0.1 | ||
| ENV MOLLY_PORT=8020 | ||
|
|
||
| RUN apt update && \ | ||
| apt install -y wget libssl3 libsqlite3-0 ca-certificates && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
|
|
||
| COPY --from=builder /app/target/release/mollysocket /usr/local/bin/ | ||
| HEALTHCHECK --interval=1m --timeout=3s \ | ||
| CMD wget -q --tries=1 "http://$MOLLY_HOST:$MOLLY_PORT/" -O - | grep '"mollysocket":{"version":' | ||
| ENTRYPOINT ["/usr/local/bin/mollysocket"] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that although this comment is intrinsically correct, github actions require additional configuration to make docker layer caching work during github workflows.
Not sure if you are interested in that because of the comment about nightly builds to resolve CVE's in the base images.