Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests #85

Merged
merged 6 commits into from
Dec 9, 2018
Merged

Fix integration tests #85

merged 6 commits into from
Dec 9, 2018

Conversation

TobiX
Copy link
Contributor

@TobiX TobiX commented Dec 5, 2018

These are a collection of changes to make the integration tests more usable:

  • Restore (most) ignored test cases by fixing the git and svn dot dirs
  • Clearly show skipped tests by using JUnit's Assume
  • More robust Subversion detection, so tests also run with SVN 1.9, 1.10 and hopefully any future versions ;)
  • Move the last test case from invoker to takeri testing

Finally, I removed the invoker tests. I think having two places with integration tests might confuse (or even discourage) new contributors to the project - If you think this is a mistake, I'll remove the last commit from this branch.

@dantran dantran merged commit 5b63353 into mojohaus:master Dec 9, 2018
@dantran dantran added this to the 3.0.0 milestone Dec 9, 2018
@TobiX TobiX deleted the fix-it branch December 9, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants