Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Footer #34

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Added Footer #34

merged 3 commits into from
Jul 25, 2022

Conversation

Palaksharma23
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Jul 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui-library ✅ Ready (Inspect) Visit Preview Jul 24, 2022 at 10:38AM (UTC)

Copy link
Collaborator

@Janvi-Thakkar Janvi-Thakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Palaksharma23, Here are some points:

  1. Please provide different color effect on hover over the links.
  2. For small screens headings are not aligned
  3. Remove left-padding from youtube icon.
  4. I think secomdary footer design needs some improvement ( not necessary ).
    Please do these minor changes and we are good to go:))

@Janvi-Thakkar
Copy link
Collaborator

hi @Palaksharma23, thank you for the quick changes. but the youtube icon is yet not aligned. please only change that one and we are good to go 🚀🚀

Copy link
Collaborator

@YashKandalkar YashKandalkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@HarshCasper HarshCasper merged commit 7387102 into moja-global:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants