-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Accordion #20
Added Accordion #20
Conversation
float: right; | ||
color: v-bind(headingcolor); | ||
padding-right: 1%; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @Palaksharma23 💯.
I am providing this as an example and you can change it at other places accordingly. as float, color, and padding properties are not changing for active classes as well, you don't need to repeat them again. you just need to mention content:'-' inside .active .label_secondary:before. rest will be inherited from .label_secondary:before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YashKandalkar @Palaksharma23 let me know your views on this.
}, | ||
Bgheading: { | ||
type: String, | ||
default: "#2e382b", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either give the name of variables in camelCase or PascalCase or snake_case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's go with camelCase
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Palaksharma23 I think you have a wrong onclick event handler somewhere, it throws an error when the description is clicked. |
Fixes #2
I have added Accordion component in this pull request