Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Accordion #20

Merged
merged 7 commits into from
Jul 25, 2022
Merged

Added Accordion #20

merged 7 commits into from
Jul 25, 2022

Conversation

Palaksharma23
Copy link
Member

Fixes #2
I have added Accordion component in this pull request

float: right;
color: v-bind(headingcolor);
padding-right: 1%;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @Palaksharma23 💯.
I am providing this as an example and you can change it at other places accordingly. as float, color, and padding properties are not changing for active classes as well, you don't need to repeat them again. you just need to mention content:'-' inside .active .label_secondary:before. rest will be inherited from .label_secondary:before

Copy link
Collaborator

@Janvi-Thakkar Janvi-Thakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YashKandalkar @Palaksharma23 let me know your views on this.

},
Bgheading: {
type: String,
default: "#2e382b",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either give the name of variables in camelCase or PascalCase or snake_case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go with camelCase

@vercel
Copy link

vercel bot commented Jul 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui-library ✅ Ready (Inspect) Visit Preview Jul 24, 2022 at 4:15PM (UTC)

Copy link
Collaborator

@Janvi-Thakkar Janvi-Thakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giving me errors
image

@YashKandalkar
Copy link
Collaborator

@Palaksharma23 I think you have a wrong onclick event handler somewhere, it throws an error when the description is clicked.
Please have a look into it.

@HarshCasper HarshCasper merged commit ee550b4 into moja-global:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Accordion Component Folder in the ui library
4 participants