-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify FLINT prerequisites #58
Clarify FLINT prerequisites #58
Conversation
Hi @HarshCasper @shubhamkarande13 @aornugent, Would you be able to review this PR? |
Could you please take a look at this @shubhamkarande13 - it should be very familiar after creating your videos! |
Amended docs to be more explicit that FLINT core repository is needed before proceeding to FLINT.example Signed-off-by: sarahhaggarty <81160244+sarahhaggarty@users.noreply.github.com>
Remove instruction to build visual studio solution from vcpkg prerequisites page as it is too early Signed-off-by: sarahhaggarty <81160244+sarahhaggarty@users.noreply.github.com>
cbe384e
to
8fda2cf
Compare
Hi @shubhamkarande13 @chicken-biryani, thank you so much for your time earlier this week to discuss this PR. It was really helpful! As we discussed, I created two new issues: #59 and #60. I reverted my suggested change about moving "Data Sets" to FLINT.example from this PR so that issue can be followed instead on #60. This leaves the following changes that we spoke about:
I double-checked the videos and the changes I've proposed have no impact as the sections which are changed are not consulted or shown in the videos. @shubhamkarande13 do you think you're OK to review this PR now? Let me know if there is anything I missed! |
Great PR @sarahhaggarty! |
@all-contributors bot please add @sarahhaggarty for docs bug mentoring review |
I've put up a pull request to add @sarahhaggarty! 🎉 |
Description
This PR is a proposal to make changes to the existing documentation to make it more explicit to the reader when to fork and clone FLINT core repository as part of the installation process. For further details and motivation please read: #57
Fixes #57
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
N/A
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist: