Added load_dontenv, changed mongo_uri load logic #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taaku18
requested changes
Sep 3, 2022
| @@ -312,84 +320,6 @@ | |||
| "markers": "python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3'", | |||
| "version": "==1.16.0" | |||
| }, | |||
| "ujson": { | |||
There was a problem hiding this comment.
Looks like you may need to run pipenv lock again. ujson and uvloop are speedup dependencies for sanic—not sure why they are removed.
Update: I tried relocking your Pipfile locally, and these two packages indeed came back. I'll merge the PR once you relock the dependencies. 😃
There was a problem hiding this comment.
I have finally managd to get these fixed with a relock. Not sure what went different this time but it magically worked. Can you review again?
Taaku18
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sebkuip
sebkuip commented 18 minutes ago
Currently modmail uses load_dotenv to not rely on pipenv. Logviewer does not have this function. This update adds this load_dotenv along with changing logic in loading the mongo_uri to be more consistent. Including a clear exit message when no mongo_uri is found.