-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates(model_splitter.py): update UnstructuredGrid support #2292
Conversation
jlarsen-usgs
commented
Aug 15, 2024
- force remapping to be calculated from iac, ja array
- add 0 digit padding to file names
- update UnstructuredGrid, add cell2d input parameter and property method
- add clean_iverts() to UnstructuredGrid to remove duplicated vertex and invert information
- update testing for new features
* force remapping to be calculated from iac, ja array * add 0 digit padding to file names * update UnstructuredGrid, add cell2d input parameter and property method * add clean_iverts() to UnstructuredGrid to remove duplicated vertex and invert information * update testing for new features
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2292 +/- ##
=========================================
+ Coverage 73.9% 74.4% +0.4%
=========================================
Files 294 294
Lines 59394 59486 +92
=========================================
+ Hits 43932 44268 +336
+ Misses 15462 15218 -244
|
@jlarsen-usgs is this ready to go in or do you have more to do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlarsen thanks for the model name padding.
@jdhughes-usgs |
…py#2292) * force remapping to be calculated from iac, ja array * add 0 digit padding to file names * update UnstructuredGrid, add cell2d input parameter and property method * add clean_iverts() to UnstructuredGrid to remove duplicated vertex and invert information * update testing for new features