Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates(model_splitter.py): update UnstructuredGrid support #2292

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

jlarsen-usgs
Copy link
Contributor

  • force remapping to be calculated from iac, ja array
  • add 0 digit padding to file names
  • update UnstructuredGrid, add cell2d input parameter and property method
  • add clean_iverts() to UnstructuredGrid to remove duplicated vertex and invert information
  • update testing for new features

* force remapping to be calculated from iac, ja array
* add 0 digit padding to file names
* update UnstructuredGrid, add cell2d input parameter and property method
* add clean_iverts() to UnstructuredGrid to remove duplicated vertex and invert information
* update testing for new features
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 72.50000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 74.4%. Comparing base (559ae74) to head (2cd8fd8).
Report is 8 commits behind head on develop.

Files Patch % Lines
flopy/discretization/unstructuredgrid.py 50.8% 29 Missing ⚠️
flopy/mf6/utils/model_splitter.py 92.4% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2292     +/-   ##
=========================================
+ Coverage     73.9%   74.4%   +0.4%     
=========================================
  Files          294     294             
  Lines        59394   59486     +92     
=========================================
+ Hits         43932   44268    +336     
+ Misses       15462   15218    -244     
Files Coverage Δ
flopy/mf6/mfmodel.py 82.8% <100.0%> (-0.2%) ⬇️
flopy/utils/rasters.py 74.2% <100.0%> (+0.3%) ⬆️
flopy/mf6/utils/model_splitter.py 70.5% <92.4%> (+0.7%) ⬆️
flopy/discretization/unstructuredgrid.py 80.8% <50.8%> (-3.8%) ⬇️

... and 10 files with indirect coverage changes

@jdhughes-usgs
Copy link
Contributor

@jlarsen-usgs is this ready to go in or do you have more to do?

Copy link
Contributor

@jdhughes-usgs jdhughes-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlarsen thanks for the model name padding.

@jlarsen-usgs
Copy link
Contributor Author

@jdhughes-usgs
It's ready to go in. I'll merge it now.

@jlarsen-usgs jlarsen-usgs merged commit d02967d into modflowpy:develop Aug 16, 2024
26 checks passed
@wpbonelli wpbonelli modified the milestones: 3.9, 3.8.1 Sep 4, 2024
martclanor pushed a commit to martclanor/flopy that referenced this pull request Sep 21, 2024
…py#2292)

* force remapping to be calculated from iac, ja array
* add 0 digit padding to file names
* update UnstructuredGrid, add cell2d input parameter and property method
* add clean_iverts() to UnstructuredGrid to remove duplicated vertex and invert information
* update testing for new features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants