Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Raster): reclassify np.float64 correctly #2235

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

martclanor
Copy link
Contributor

@martclanor martclanor commented Jun 14, 2024

Just a small fix on dtype reclassification when creating a Raster object.

I was also tempted to reclassify float as FLOAT64 and int as INT64 because based on my quick search, Python's float is represented as 64-bit, and int is pretty much unbounded. But then maybe these might be intended for optimization purposes as FLOAT32 and INT32 are practically sufficient in most cases.

@martclanor martclanor marked this pull request as ready for review June 14, 2024 20:44
@wpbonelli wpbonelli added the bug label Jun 19, 2024
@jlarsen-usgs jlarsen-usgs merged commit a2a159f into modflowpy:develop Jun 24, 2024
24 checks passed
@martclanor martclanor deleted the raster_dtype_reclass branch August 11, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants