fix(Raster): reclassify np.float64 correctly #2235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small fix on dtype reclassification when creating a
Raster
object.I was also tempted to reclassify
float
asFLOAT64
andint
asINT64
because based on my quick search, Python'sfloat
is represented as 64-bit, andint
is pretty much unbounded. But then maybe these might be intended for optimization purposes asFLOAT32
andINT32
are practically sufficient in most cases.