fix(ParticleTrackFile): fetch correct particleids in get_alldata #2223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the fetching of correct particleids in the
get_alldata
method ofParticleTrackFile
.This mppth file, pathlinefile.zip, is an output of a modpath simulation with the following log:
In this simulation,
107
out of658
particles were successfully tracked. If the mppth is read as aParticleTrackFile
and if theget_alldata
method is called on it,pl_data
is returned as a list of length107
but with all elements being empty arrays.Iiuc, that is because the
get_alldata
method uses the first107
particles which are not necessarily the ones that were tracked successfully.